svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64 i...

[Ian Lepore]

On Wed, 2016-01-13 at 00:43 +0000, Steven Hartland wrote:
> On 13/01/2016 00:41, Ian Lepore wrote:
> > On Tue, 2016-01-12 at 02:17 +0000, Steven Hartland wrote:
> > > Author: smh
> > > Date: Tue Jan 12 02:17:39 2016
> > > New Revision: 293724
> > > URL: https://svnweb.freebsd.org/changeset/base/293724
> > > 
> > > Log:
> > >    Enable warnings in EFI boot code
> > >    
> > >    Set WARNS if not set for EFI boot code and fix the issues
> > > highlighted by
> > >    setting it.
> > >    
> > This appears to break arm builds when gcc is the compiler:
> > 
> > cc1: warnings being treated as errors
> > In file included from
> > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e
> > fi.h:52,
> >                   from
> > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/efi_fdt.c:35
> > :
> > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e
> > fiapi.h:535: warning: function declaration isn't a prototype
> > In file included from
> > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/efi_fdt.c:39
> > :
> > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../../common
> > /bootstrap.h:332: warning: redundant redeclaration of 'delay'
> > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e
> > filib.h:53: warning: previous declaration of 'delay' was here
> > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../../common
> > /bootstrap.h:336: warning: redundant redeclaration of 'time'
> > /bsdstg/rm92/obj/arm.arm/local/build/staging/freebsd/rm92/src/tmp/u
> > sr/include/time.h:154: warning: previous declaration of 'time' was
> > here
> > 
> > -- Ian
> Passes a full tinderbox so I assume your forcing gcc for some reason?

For several reasons.  The fact that gcc isn't the default compiler
doesn't mean that it's okay for code to not compile with gcc; it's
still a supported compiler for arm.

-- Ian