svn commit: r293112 - head/sys/dev/ixl

NGie Cooper yaneurabeya at gmail.com
Mon Jan 4 22:45:51 UTC 2016


On Sun, Jan 3, 2016 at 2:23 PM, John Baldwin <jhb at freebsd.org> wrote:

...

> FWIW, it is probably simpler to do something like this in an ixl header instead:
>
> #if __FreeBSD_version <= 1100022
> #define if_getdrvflags(ifp)     (ifp)->if_drv_flags
> #endif
>
> In the past when the Intel drivers have used compat shims they have preferred this
> method (defining compat macros for "new" APIs on old OS versions) instead of using
> #ifdef's in the code itself.

You're right. What I did was incredibly ugly and only fixes one
potential instance (of which more might appear later).. I'll send out
a CR moving the definition to a header file and commit the change.
Thanks!
-NGie


More information about the svn-src-all mailing list