svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress

[Maxim Sobolev]

Sigh, I don't now how it managed to sleep through usually tight FreeBSD
peer-review process. It would be interesting to hear some comments from
@ray and @adrian, perhaps there were some reasons for it being done this
way, although I cannot see any in a hindsight.

I am just in the middle of rather substantial overhaul of both kernel and
userland part here:

https://reviews.freebsd.org/D5333

And once that committed it will take them apart again. I've also spend
quite lot of time testing my change set, which would with very little
effort have covered both formats had I started with unified code base. :(

I also plan on making further improvement into kernel module, as it is
right now both g_uzip and g_uncompress basically piggyback single "g_up"
thread, so you cannot use multiple cores even for different instances, let
alone one instance being accessed by multiple readers. And it also can
delay other unrelated I/O requests by maxing out CPU time slice available
for the g_up.

On Thu, Feb 18, 2016 at 4:38 PM, Bryan Drewery <bdrewery at freebsd.org> wrote:

> On 2/18/2016 3:57 PM, Maxim Sobolev wrote:
> > Aleksandr, Adrian,
> >
> > I know it's 3 years later, but I really don't know why it's been done
> > this way. Take a GEOM module and associated usr.bin utility, copy it
> > verbatim add few lines of code and re-add that as a new module seems
> > like just laziness and attempt to avoid doing extra work on making
> > unified code. The same goes for the mkulzma, which is almost 1:1 copy of
> > the mkuzip. Now people are merging back and forth and I've just spent
> > few days testing some rather major rework of geom_uzip / mkuzip code not
> > even realizing that there is its evil twin in the tree. :(
>
> r283104 is an example of one of these problems. It was a catch-up of
> uzip's r268986 done almost a year before. I did comparisons before using
> uzip last summer and ran across that one.
>
> >
> > https://reviews.freebsd.org/D5333
> >
> > I suggest functionality from both geom_uncompress / mkulzma are folded
> > now back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked
> > afterwards.
> >
> > Thanks!
> >
> >
> >
> >     Author: ray
> >     Date: Wed Jan 4 23:39:11 2012
> >     New Revision: 229537
> >     URL: http://svn.freebsd.org/changeset/base/229537
> >     Log:
> >     GEOM_UNCOMPRESS module, can be used with uzip images and with new
> >     ulzma images.
> >     Approved by: adrian (mentor)
> >     Added:
> >     head/sys/geom/uncompress/
> >     head/sys/geom/uncompress/g_uncompress.c (contents, props changed)
> >     head/sys/modules/geom/geom_uncompress/
> >     head/sys/modules/geom/geom_uncompress/Makefile (contents, props
> changed)
> >     Modified:
> >     head/sys/conf/files
> >     head/sys/conf/options
> >
> >
>
>
> --
> Regards,
> Bryan Drewery
>
>


-- 
Maksym Sobolyev
Sippy Software, Inc.
Internet Telephony (VoIP) Experts
Tel (Canada): +1-778-783-0474
Tel (Toll-Free): +1-855-747-7779
Fax: +1-866-857-6942
Web: http://www.sippysoft.com
MSN: sales at sippysoft.com
Skype: SippySoft