svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress

Maxim Sobolev sobomax at FreeBSD.org
Thu Feb 18 23:57:47 UTC 2016


Aleksandr, Adrian,

I know it's 3 years later, but I really don't know why it's been done this
way. Take a GEOM module and associated usr.bin utility, copy it verbatim
add few lines of code and re-add that as a new module seems like just
laziness and attempt to avoid doing extra work on making unified code. The
same goes for the mkulzma, which is almost 1:1 copy of the mkuzip. Now
people are merging back and forth and I've just spent few days testing some
rather major rework of geom_uzip / mkuzip code not even realizing that
there is its evil twin in the tree. :(

https://reviews.freebsd.org/D5333

I suggest functionality from both geom_uncompress / mkulzma are folded now
back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked
afterwards.

Thanks!



> Author: ray
> Date: Wed Jan 4 23:39:11 2012
> New Revision: 229537
> URL: http://svn.freebsd.org/changeset/base/229537
> Log:
> GEOM_UNCOMPRESS module, can be used with uzip images and with new ulzma
> images.
> Approved by: adrian (mentor)
> Added:
> head/sys/geom/uncompress/
> head/sys/geom/uncompress/g_uncompress.c (contents, props changed)
> head/sys/modules/geom/geom_uncompress/
> head/sys/modules/geom/geom_uncompress/Makefile (contents, props changed)
> Modified:
> head/sys/conf/files
> head/sys/conf/options


More information about the svn-src-all mailing list