svn commit: r295608 - head/sys/dev/usb/net

[Hans Petter Selasky]

Author: hselasky
Date: Sun Feb 14 07:20:07 2016
New Revision: 295608
URL: https://svnweb.freebsd.org/changeset/base/295608

Log:
  Fix variable assignment inside if-clause in the smsc driver.
  Found by D5245 / PVS.
  
  MFC after:	1 week

Modified:
  head/sys/dev/usb/net/if_smsc.c

Modified: head/sys/dev/usb/net/if_smsc.c
==============================================================================
--- head/sys/dev/usb/net/if_smsc.c	Sun Feb 14 07:16:36 2016	(r295607)
+++ head/sys/dev/usb/net/if_smsc.c	Sun Feb 14 07:20:07 2016	(r295608)
@@ -1362,7 +1362,7 @@ smsc_chip_init(struct smsc_softc *sc)
 	/* Reset the PHY */
 	smsc_write_reg(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST);
 
-	if ((err = smsc_wait_for_bits(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST) != 0)) {
+	if ((err = smsc_wait_for_bits(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST)) != 0) {
 		smsc_warn_printf(sc, "timed-out waiting for phy reset to complete\n");
 		goto init_failed;
 	}