svn commit: r295510 - head/sys/dev/xen/netfront
Roger Pau Monné
royger at FreeBSD.org
Thu Feb 11 11:50:33 UTC 2016
Author: royger
Date: Thu Feb 11 11:50:31 2016
New Revision: 295510
URL: https://svnweb.freebsd.org/changeset/base/295510
Log:
xen-netfront: remove pointless assignment in xn_ioctl
The variable error is assigned to 0 before entering the switch.
Assigning error to 0 before break pointless rewrites the real error
value that should be returned.
Coverity ID: 1304974
Submitted by: Wei Liu <wei.liu2 at citrix.com>
Reviewed by: royger
Sponsored by: Citrix Systems R&D
Differential revision: https://reviews.freebsd.org/D5250
Modified:
head/sys/dev/xen/netfront/netfront.c
Modified: head/sys/dev/xen/netfront/netfront.c
==============================================================================
--- head/sys/dev/xen/netfront/netfront.c Thu Feb 11 11:49:27 2016 (r295509)
+++ head/sys/dev/xen/netfront/netfront.c Thu Feb 11 11:50:31 2016 (r295510)
@@ -1863,7 +1863,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd,
}
sc->xn_if_flags = ifp->if_flags;
XN_UNLOCK(sc);
- error = 0;
break;
case SIOCSIFCAP:
mask = ifr->ifr_reqcap ^ ifp->if_capenable;
@@ -1898,7 +1897,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd,
ifp->if_capenable ^= IFCAP_LRO;
}
- error = 0;
break;
case SIOCADDMULTI:
case SIOCDELMULTI:
More information about the svn-src-all
mailing list