svn commit: r295226 - head/lib/libmemstat

[John Baldwin]

On Thursday, February 04, 2016 09:06:03 AM Gleb Smirnoff wrote:
> On Wed, Feb 03, 2016 at 04:41:26PM -0800, Bryan Drewery wrote:
> B> On 2/3/2016 4:23 PM, Gleb Smirnoff wrote:
> B> > Author: glebius
> B> > Date: Thu Feb  4 00:23:21 2016
> B> > New Revision: 295226
> B> > URL: https://svnweb.freebsd.org/changeset/base/295226
> B> > 
> B> > Log:
> B> >   Fix build.
> B> > 
> B> > Modified:
> B> >   head/lib/libmemstat/memstat_uma.c
> B> > 
> B> > Modified: head/lib/libmemstat/memstat_uma.c
> B> > ==============================================================================
> B> > --- head/lib/libmemstat/memstat_uma.c	Wed Feb  3 23:41:58 2016	(r295225)
> B> > +++ head/lib/libmemstat/memstat_uma.c	Thu Feb  4 00:23:21 2016	(r295226)
> B> > @@ -29,6 +29,7 @@
> B> >  #include <sys/param.h>
> B> >  #include <sys/cpuset.h>
> B> >  #include <sys/sysctl.h>
> B> > +#include <sys/_task.h>
> B> >  
> B> >  #include <vm/vm.h>
> B> >  #include <vm/vm_page.h>
> B> > 
> B> 
> B> Shouldn't uma_int.h forward declare or include _task.h for struct task?
> 
> Forward declaration won't work, since structure is included, not pointed at.
> I'm reluctant with adding includes into includes.

The sys/_foo.h headers are specifically designed so they can be used as nested
includes while (hopefully) introducing minimal pollution.  If you are embedding
struct task in a structure, use a nested include of <sys/_task.h>.  That is
why <sys/_task.h> exists as a separate header from <sys/taskqueue.h>.

-- 
John Baldwin