svn commit: r310171 - head/sys/sys

Ian Lepore ian at freebsd.org
Mon Dec 19 19:20:19 UTC 2016


On Mon, 2016-12-19 at 11:58 -0700, Warner Losh wrote:
> On Mon, Dec 19, 2016 at 1:39 AM, Ravi Pokala <rpokala at mac.com> wrote:
> > 
> > -----Original Message-----
> > > 
> > > From: <owner-src-committers at freebsd.org> on behalf of Sepherosa
> > > Ziehau <sepherosa at gmail.com>
> > > Date: 2016-12-18, Sunday at 23:02
> > > To: Dimitry Andric <dim at freebsd.org>
> > > Cc: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn
> > > -src-head at freebsd.org>
> > > Subject: Re: svn commit: r310171 - head/sys/sys
> > > 
> > > The following patch unbreaks the LINT builds on amd64 for me
> > > after this commit:
> > > https://people.freebsd.org/~sephe/geom_sscanf.diff
> > Wouldn't it be better to use the SCN macros?
> Are there other precedence for avoiding the SCN macros in the tree as
> well, or is this new art?
> 
> Warner

There was another commit recently the fixed the same kind of scanf
error by making the variable fit the scanf type (changing uint64_t to
an explicit long long unsigned, iirc).  I don't know if that alone
counts as a precedent, but IMO it's a more palatible fix than the
SCN/PRI ugliness.

-- Ian



More information about the svn-src-all mailing list