svn commit: r308371 - in stable/10: share/man/man4 sys/conf sys/dev/jedec_ts sys/modules/i2c sys/modules/i2c/jedec_ts

[John Baldwin]

On Wednesday, December 14, 2016 05:41:47 PM Andriy Gapon wrote:
> On 05/12/2016 23:49, John Baldwin wrote:
> > On Sunday, November 06, 2016 01:56:34 PM Andriy Gapon wrote:
> >> Author: avg
> >> Date: Sun Nov  6 13:56:34 2016
> >> New Revision: 308371
> >> URL: https://svnweb.freebsd.org/changeset/base/308371
> >>
> >> Log:
> >>   MFC r307768: jedec_ts: a driver for thermal sensors on memory modules
> >>
> >> Added:
> >>   stable/10/share/man/man4/jedec_ts.4
> >>      - copied unchanged from r307768, head/share/man/man4/jedec_ts.4
> >>   stable/10/sys/dev/jedec_ts/
> >>      - copied from r307768, head/sys/dev/jedec_ts/
> >>   stable/10/sys/modules/i2c/jedec_ts/
> >>      - copied from r307768, head/sys/modules/i2c/jedec_ts/
> >> Modified:
> >>   stable/10/sys/conf/NOTES
> >>   stable/10/sys/conf/files
> >>   stable/10/sys/modules/i2c/Makefile
> >> Directory Properties:
> >>   stable/10/   (props changed)
> > 
> > FYI, this doesn't work and has broken tinderbox builds on stable/10.
> > smbus_get_addr() doesn't exist on 10.  It was originally a hand-rolled
> > ivar wrapper that was removed in r93023 in 2002.  The function prototype
> > was not removed, so the compile works, but linking fails.  The stale
> > prototype is still present in smbconf.h in HEAD (and should be removed).
> > The "real" smbus_get_addr() was added back to smbconf.h along with an
> > implementation of smbus_read_ivar() in r281985.  Parts of that commit
> > probably need to be MFC'd to 10.
> > 
> 
> John,
> 
> thank you for catching this and sorry for the trouble.
> Could you please check if r310062 really fixes the problem?

Yes.  Well, it fixes linking of kernels at least.  Now make tinderbox
on 10 fails for the following kernels:

_.ia64.GENERIC: Maxmem is not available on ia64.  It is spelled
    paddr_max instead.  The firewire code is trying to use Maxmem.
_.ia64.LINT: Same.
_.arm.LINT: Many link errors and warnings, though lack of 'kbd_*' symbols
    seems to be the only actual errors.

I suspect you recently MFC'd changes to fwohci.c that are using Maxmem.
However, I'm not sure it is worth fixing fwohci on ia64.

-- 
John Baldwin