svn commit: r310232 - head/sys/dev/mlx4/mlx4_ib

[Ed Schouten]

2016-12-18 16:21 GMT+01:00 Dimitry Andric <dim at freebsd.org>:
> Modified: head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c
> ==============================================================================
> --- head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c   Sun Dec 18 15:10:08 2016        (r310231)
> +++ head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c   Sun Dec 18 15:21:38 2016        (r310232)
> @@ -79,7 +79,7 @@ static ssize_t store_admin_alias_guid(st
>                 container_of(attr, struct mlx4_ib_iov_sysfs_attr, dentry);
>         struct mlx4_ib_iov_port *port = mlx4_ib_iov_dentry->ctx;
>         struct mlx4_ib_dev *mdev = port->dev;
> -       u64 sysadmin_ag_val;
> +       unsigned long long sysadmin_ag_val;
>
>         record_num = mlx4_ib_iov_dentry->entry_num / 8;
>         guid_index_in_rec = mlx4_ib_iov_dentry->entry_num % 8;

Looking at the code, the intent is that an actual 64-bit integer is
parsed; not an unsigned long long. What's wrong with using
inttypes.h's SCNx64?

-- 
Ed Schouten <ed at nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717