svn commit: r307684 - head/sbin/camcontrol

[Oliver Pinter]

On 12/12/16, Kenneth D. Merry <ken at freebsd.org> wrote:
> On Sun, Dec 11, 2016 at 00:49:12 +0100, Oliver Pinter wrote:
>> On 10/20/16, Kenneth D. Merry <ken at freebsd.org> wrote:
>> > Author: ken
>> > Date: Thu Oct 20 19:42:26 2016
>> > New Revision: 307684
>> > URL: https://svnweb.freebsd.org/changeset/base/307684
>> >
>> > Log:
>> >   For CCBs allocated on the stack, we need to clear the entire CCB, not
>> > just
>> >   the header.  Otherwise stack garbage can lead to random flags getting
>> > set.
>> >
>> >   This showed up as 'camcontrol rescan all' failing with EINVAL because
>> > the
>> >   address type wasn't CAM_DATA_VADDR.
>> >
>> >   sbin/camcontrol/camcontrol.c:
>> >   	In rescan_or_reset_bus(), bzero the stack-allocated CCBs before
>> >   	use instead of clearing the body.
>> >
>> >   MFC after:	3 days
>> >   Sponsored by:	Spectra Logic
>>
>> The MFC of this commit is missed both for 10-STABLE and 11-STABLE. Is
>> this still in plan to do?
>
> Done, thanks for the reminder!

Thanks!

Slightly related problem what I found on one of my INVARIANTS enabled
kernel is the following:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215356 . A similar
change what this is required in smartmontools too.

>
> Ken
> --
> Kenneth Merry
> ken at FreeBSD.ORG
>