svn commit: r310051 - in head: share/man/man9 sys/kern sys/sys

[Dimitry Andric]

On 17 Dec 2016, at 10:43, Ed Schouten <ed at nuxi.nl> wrote:
> 
> 2016-12-16 23:55 GMT+01:00 Dimitry Andric <dim at freebsd.org>:
>> Since this now causes VMware kernel modules to insta-panic the kernel,
>> it might be nice to put some warning in UPDATING, at least.  Luckily
>> __FreeBSD_version got bumped by Adrian in r310149 for something
>> unrelated, but this is definitely something to notify maintainers of
>> ports (with kernel modules) about too.
> 
> This change affects the KBI, as sysctl declarations now include an
> additional pointer. The underlying sysctl registration function also
> gained an additional argument. That said, if you simply rebuild all
> kernel modules, this shouldn't cause any regressions, or are you
> saying those persist? If so, this is definitely not an intended
> side-effect of this change and we should look into it.

Well, the kernel module doesn't compile anymore, of course:

os.c:894:46: error: too few arguments to function call, expected 11, have 10
                         BALLOON_NAME_VERBOSE);
                                             ^
/usr/src/sys/sys/sysctl.h:1014:1: note: 'sysctl_add_oid' declared here
struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist,
^
1 error generated.

I am unsure why the VMware modules don't use the SYSCTL_XXX macros.
Maybe these were not available in the past?  Only the original
maintainers might know.

In any case, I have submitted a PR with a build fix, making use of the
unrelated __FreeBSD_version bump, to add an additional NULL parameter
to the call:

https://bugs.freebsd.org/215353

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20161217/ca59a1d4/attachment.sig>