svn commit: r309350 - head/etc

Ian Lepore ian at freebsd.org
Thu Dec 1 16:36:36 UTC 2016


On Thu, 2016-12-01 at 04:35 +0000, Warner Losh wrote:
> Author: imp
> Date: Thu Dec  1 04:35:41 2016
> New Revision: 309350
> URL: https://svnweb.freebsd.org/changeset/base/309350
> 
> Log:
>   If the kenv variable rc_debug is set, turn on rc_debug.
> 
> Modified:
>   head/etc/rc.subr
> 
> Modified: head/etc/rc.subr
> =====================================================================
> =========
> --- head/etc/rc.subr	Thu Dec  1 04:35:38 2016	(r309349)
> +++ head/etc/rc.subr	Thu Dec  1 04:35:41 2016	(r309350)
> @@ -2119,6 +2119,12 @@ _echoonce()
>  	esac
>  }
>  
> +# If the loader env variable rc.debug is set, turn on debugging.
> rc.conf will
> +# still override this, but /etc/defaults/rc.conf.a
> +if kenv -q rc.debug > /dev/null ; then
> +	rc_debug=YES
> +fi
> +
>  fi # [ -z "${_rc_subr_loaded}" ]
>  
>  _rc_subr_loaded=:
> 

The commit message says rc_debug but the env var in your code is
rc.debug.  I think rc_debug would be better -- easier than remembering
two different names for the same functionality.

BTW, thanks for this, it's a great idea.

-- Ian




More information about the svn-src-all mailing list