svn commit: r309344 - head/lib/libutil

[Ian Lepore]

On Wed, 2016-11-30 at 19:07 -0800, Ngie Cooper wrote:
> > 
> > On Nov 30, 2016, at 18:21, Conrad E. Meyer <cem at FreeBSD.org> wrote:
> > 
> > Author: cem
> > Date: Thu Dec  1 02:21:36 2016
> > New Revision: 309344
> > URL: https://svnweb.freebsd.org/changeset/base/309344
> > 
> > Log:
> >  Remove a death threat from the FreeBSD sources
> > 
> >  Reported by:    koobs@, araujo@, linimon@, bjk@, emaste@, jhb@,
> > ngie@, cem@
> >  Maintainer timeout:    des@
> Really?? I wish you hadn't added me to this list.. I don't in any way
> endorse the way that you went about dealing with this disagreement.
> You kind of just pissed all over what des@ did out of spite.
> 
> </rant>

Really?  Well then feel free to ADD my name to the list of people who
found that comment, and the subsequent non-response to the complaints
about it, completely inappropriate.  

-- Ian


> > 
> > 
> > Modified:
> >  head/lib/libutil/flopen.c
> > 
> > Modified: head/lib/libutil/flopen.c
> > ===================================================================
> > ===========
> > --- head/lib/libutil/flopen.c    Thu Dec  1 01:56:34
> > 2016    (r309343)
> > +++ head/lib/libutil/flopen.c    Thu Dec  1 02:21:36
> > 2016    (r309344)
> > @@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$");
> > /*
> >  * Reliably open and lock a file.
> >  *
> > - * DO NOT, UNDER PAIN OF DEATH, modify this code without first
> > reading the
> > - * revision history and discussing your changes with <des at freebsd.
> > org>.
> > - * Don't be fooled by the code's apparent simplicity; there would
> > be no
> > - * need for this function if it was as easy to get right as you
> > think.
> > + * Please do not modify this code without first reading the
> > revision history
> > + * and discussing your changes with <des at freebsd.org>.  Don't be
> > fooled by the
> > + * code's apparent simplicity; there would be no need for this
> > function if it
> > + * was easy to get right.
> >  */
> > int
> > flopen(const char *path, int flags, ...)
> > @@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...)
> >            errno = serrno;
> >            return (-1);
> >        }
> > -#ifdef DONT_EVEN_THINK_ABOUT_IT
> > +        /*
> > +         * The following change is provided as a specific example
> > to
> > +         * avoid.
> > +         */
> > +#if 0
> >        if (fcntl(fd, F_SETFD, FD_CLOEXEC) != 0) {
> >            serrno = errno;
> >            (void)close(fd);
> > 
>