svn commit: r303988 - head/lib/libc/gen

[Bryan Drewery]

On 8/26/2016 12:57 PM, John Baldwin wrote:
> On Friday, August 26, 2016 09:37:10 AM Ed Schouten wrote:
>> Hi,
>>
>> 2016-08-26 1:52 GMT+02:00 Bryan Drewery <bdrewery at freebsd.org>:
>>> Libc wouldn't build, it complained quite loudly with a lot of these:
>>
>> Got it. Thinking ahead, if it's just basename() giving the problems,
>> maybe it's easier to just go ahead and bump the symver of basename()
>> as well? I'm planning on replacing it anyway to be in sync with the
>> new basename() anyway. Attached is a new patch. Be sure to let me know
>> whether that works for you.
> 
> Alternatively, couldn't you just leave basename out of the libgen patch
> for now and only add it once you do the real symver bump for the
> different version?  (That is, just use __generic() for dirname() for
> now since that is the only one that has really changed.)
> 

Doing this also works.

I think it was done since the prototype did change as well which
disallows building the old xinstall directly, but in the bootstrap build
it is built with MK_WARNS=no so the error is ignored.

> /usr/local/bin/ccache cc -O2 -pipe   -I/root/svn/releng/11.0/usr.bin/xinstall/../../contrib/mtree -I/root/svn/releng/11.0/usr.bin/xinstall/../../lib/libnetbsd -g -std=gnu99 -fstack-protector-strong -Qunused-arguments  -c /root/svn/releng/11.0/usr.bin/xinstall/xinstall.c -o xinstall.o
> /root/svn/releng/11.0/usr.bin/xinstall/xinstall.c:696:17: warning: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
>                 cp = basename(to_name);
>                               ^~~~~~~
> /usr/include/libgen.h:37:22: note: passing argument to parameter here
> char    *basename(char *);
>                         ^
> 1 warning generated.
> Building /usr/obj/root/svn/releng/11.0/usr.bin/xinstall/getid.o


Let's just not forget to add the _generic in if/when needed too.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20160826/66afa9ac/attachment.sig>