svn commit: r304436 - in head: . sys/netinet

[Bruce Simpson]

On 21/08/16 00:25, Bruce Simpson wrote:
> On 20/08/16 23:05, Slawa Olhovchenkov wrote:
>> In router case receiving broadcast packet in any way need additional
>> check for dst IP address (host part is all zero or all one? what about
>> handling this broadcast type (RFC talk about conroling variation of
>> this)? what about sysctl control of receiving routed broadcast
>> packets? what about handling 255.255.255.255?)
>
> I believe most of this is already special-cased in ip_fastfwd.c (which
> gnn@ of course has merged, as it's full of sensible FIB-like operators
> which most router forwarding planes adopt on *their* IP input paths up
> to the forwarding decision), assuming the Ethernet input path colours
> packets with the right flags.

Just for reference, many of these 'sensible FIB operators' in the former 
ip_fastfwd.c came from the experience of James Jun at Towardex Systems. 
I merged his patch on the job whilst staying in Berkeley, CA and working 
on XORP at ICSI.

I was only too happy to do that on their ticket, as it covered a lot of 
little performance cases which the pure rtalloc() fallthrough made us 
wince about.