svn commit: r304439 - head/sys/dev/usb/net

Hans Petter Selasky hps at selasky.org
Fri Aug 19 09:07:29 UTC 2016


On 08/19/16 10:55, YongHyeon PYUN wrote:
> I think the order is right but it was not tested on big-endian
> systems.

Hi,

I'm pretty sure the ifdef is wrong, because you write the fields one at 
a time, using htole32():

                         txhdr.mss = 0;
                         txhdr.len = htole32(AXGE_TXBYTES(m->m_pkthdr.len));

Big endian machines don't re-order variables like this.

You should remove the #else part.

--HPS


More information about the svn-src-all mailing list