svn commit: r304142 - head/usr.sbin/bsdinstall/partedit

[Dag-Erling Smørgrav]

Nathan Whitehorn <nwhitehorn at freebsd.org> writes:
> As a note for people who weren't paying attention to the bug, we need
> to fix this in a better way outside of the constraints of getting 11.0
> out the door. The system (gpart, the installer, ZFS, etc.) uses the
> reported GEOM stripesize for partition alignment and IO block size
> selection. If that is wrong, we should identify devices on which it is
> wrong and fix them, and maybe also add some global tunable that sets a
> floor on the numbers reported by GEOM_DISK. Hacking the installer like
> this is triage, which is fine, but not viable as a permanent solution
> to anything.

Modifying GEOM to report a bogus number when none is provided by the
lower layer(s) is absolutely not going to happen.  You have absolutely
no idea what your proposed change will break.  And you keep refusing to
address the fact that most drivers don't report a stripe size, except by
repeating your claim that they do, with no evidence to back it up.  Feel
free to 'grep -r stripesize /usr/src/sys/dev'.  Go on, I'll wait.

Your contention that the installer does not make policy decisions is
equally spurious.  The installer makes many policy decisions, including
the disk layout, the size of the swap partition, the name of the pool,
the use of boot environments (which I dislike but am not allowed to
override), the number of filesets and their mountpoints (which I also
dislike and am not allowed to override either), etc.  The Unix
philosophy is to push such decisions up the stack, not down.  The
decision to align partitions on 4096-byte boundaries because we're not
sure of the correct number but know for a fact that using a smaller
number can have a huge impact on performance is the installer's to make.

DES
-- 
Dag-Erling Smørgrav - des at des.no