svn commit: r298678 - head/sys/kern

[Conrad E. Meyer]

Author: cem
Date: Wed Apr 27 00:10:32 2016
New Revision: 298678
URL: https://svnweb.freebsd.org/changeset/base/298678

Log:
  posix4_mib: Don't overrun facility_initialized array
  
  The facility_initialized and facility arrays are the same size and were
  intended to be indexed the same.  I believe this mismatch was just a
  typo/braino in r208731.
  
  Reported by:	Coverity
  CID:		1017430
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/sys/kern/posix4_mib.c

Modified: head/sys/kern/posix4_mib.c
==============================================================================
--- head/sys/kern/posix4_mib.c	Tue Apr 26 23:58:55 2016	(r298677)
+++ head/sys/kern/posix4_mib.c	Wed Apr 27 00:10:32 2016	(r298678)
@@ -113,9 +113,9 @@ p31b_sysctl_proc(SYSCTL_HANDLER_ARGS)
 	num = arg2;
 	if (!P31B_VALID(num))
 		return (EINVAL);
-	val = facility_initialized[num] ? facility[num - 1] : 0;
+	val = facility_initialized[num - 1] ? facility[num - 1] : 0;
 	error = sysctl_handle_int(oidp, &val, 0, req);
-	if (error == 0 && req->newptr != NULL && facility_initialized[num])
+	if (error == 0 && req->newptr != NULL && facility_initialized[num - 1])
 		facility[num - 1] = val;
 	return (error);
 }
@@ -137,7 +137,7 @@ p31b_unsetcfg(int num)
 {
 
 	facility[num - 1] = 0;
-	facility_initialized[num -1] = 0;
+	facility_initialized[num - 1] = 0;
 }
 
 int