svn commit: r298426 - head/sys/dev/fdc

John Baldwin jhb at freebsd.org
Fri Apr 22 17:02:38 UTC 2016


On Thursday, April 21, 2016 08:44:15 PM Hans Petter Selasky wrote:
> On 04/21/16 20:37, John Baldwin wrote:
> > -		tsleep(fdc, PRIBIO, "fdcrst", hz);
> > +		if (cold)
> > +			DELAY(1000000);
> > +		else
> > +			tsleep(fdc, PRIBIO, "fdcrst", hz);
> 
> Hi,
> 
> pause() and pause_sbt() does exactly this, checking for "cold" and using 
> DELAY().

Yes, I know.  In theory though the driver interrupt could fire during
normal operation aborting the sleep, so the wait channel for the !cold
case is actually there for a reason it seems.  (That is, in the !cold case
the driver might terminate the sleep early which you can't do with pause.)

-- 
John Baldwin


More information about the svn-src-all mailing list