svn commit: r298247 - head/sbin/fdisk_pc98

[Marcelo Araujo]

2016-04-20 0:16 GMT+08:00 John Baldwin <jhb at freebsd.org>:

> On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote:
> > Author: araujo
> > Date: Tue Apr 19 04:46:13 2016
> > New Revision: 298247
> > URL: https://svnweb.freebsd.org/changeset/base/298247
> >
> > Log:
> >   Remove redundant parenthesis.
> >
> >   Submitted by:       pfg
> >   MFC after:  2 weeks.
>
> For this case, it might be better to remove numentries and use
> nitems() directly in the one place it is used.  I would probably
> even do this as a for-loop:
>
>         struct part_type *ptr;
>         int counter;
>
>         for (counter = 0, ptr = part_types; counter < nitems(part_types);
>             counter++, ptr++) {
>                 if (ptr->type == (type & 0x7f))
>                         return (ptr->name);
>         }
>         return ("unknown");
>
> If you renamed 'counter' to 'i' you could probably fit it all on one line.
>
> --
> John Baldwin
>

Hi John,

Yeap, make sense!
I came up with something like:

        struct  part_type *ptr = part_types;

        for (int i = 0; i < nitems(part_types); i++) {
                if (ptr->type == (type & 0x7f))
                        return (ptr->name);
                ptr++;
        }
        return("unknown");


What do you think?

Best,
-- 

-- 
Marcelo Araujo            (__)araujo at FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>   \/  \ ^
Power To Server.         .\. /_)