svn commit: r297802 - head/sys/dev/hyperv/vmbus

[Sepherosa Ziehau]

Yeah, sure.

On Mon, Apr 11, 2016 at 1:23 PM, Ravi Pokala <rpokala at mac.com> wrote:
> Hi sephe,
>
>
>
> -----Original Message-----
> From: <owner-src-committers at freebsd.org> on behalf of Sepherosa Ziehau <sephe at FreeBSD.org>
> Date: 2016-04-10, Sunday at 20:28
> To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
> Subject: svn commit: r297802 - head/sys/dev/hyperv/vmbus
>
>>Author: sephe
>>Date: Mon Apr 11 03:28:17 2016
>>New Revision: 297802
>>URL: https://svnweb.freebsd.org/changeset/base/297802
>>
>>Log:
>>  hyperv: Identify Hyper-V features and recommends properly
>>
>>  Features bits will be used to detect devices, e.g. timers, which
>>  do not have corresponding event channels.
>>
>>  ...
>>
>>+      op = HV_CPU_ID_FUNCTION_HV_INTERFACE;
>>+      do_cpuid(op, regs);
>>+      if (regs[0] != 0x31237648 /* HV#1 */)
>>+              return (false);
>
> Could you make that a #defined constant, rather than a magic integer?
>
> Thanks,
>
> Ravi (rpokala@)
>



-- 
Tomorrow Will Never Die