svn commit: r287892 - head/sys/dev/usb/wlan

Hans Petter Selasky hps at selasky.org
Thu Sep 17 07:52:25 UTC 2015


Hi Adrian,

On 09/17/15 09:43, Adrian Chadd wrote:
> .. I'm likely going to do exactly that as part of "making" if_rsu do
> 11n and behave correctly. Right now it does neither.

Thank you for helping out with the USB WLAN drivers. Yes, USB requests 
sleep and don't spin until they're done.

>
> But this is a pretty big design pattern flaw; all of the wifi drivers
> use the usb library like this and .. well, unless you look under the
> hood, you don't really realise that serialiser lock is being dropped
> for you... :(

Right. If you need any help test, code or review, let me know.

Not dropping the mutex inside USB sleeping functions would force all USB 
drivers to use SX locks or lower in the locking hierherachy, for 
synchronization, which would not be so good.

--HPS



More information about the svn-src-all mailing list