svn commit: r287465 - head/sys/dev/e1000

Garrett Cooper yaneurabeya at gmail.com
Sun Sep 13 00:56:33 UTC 2015


> On Sep 12, 2015, at 15:45, hiren panchasara <hiren at strugglingcoder.info> wrote:
> 
>> On 09/12/15 at 07:23P, Eric Joyner wrote:
>> For the errata, the (lack of) details are in the specification updates for
>> HW like I210, I211, 82575 etc. It would be in the ones updated in August
>> 2015.
> 
> Yes, I (we) know erratas are there in the h/w specs. Point is, which
> exact errata problem are you fixing here so I can go look up the spec
> for more detail. Errata number/name and exact spec should also be quoted
> for less ambiguity. (Think about someone having to debug this code 5
> years down the road.)

    As a general request, better commit notes would help a lot when dealing with driver porting/upgrades. There are a few times in the past where I've tried upgrading things or cherry picking commits and decided against it (or ran into other issues), so having more info to provide to management and test would be extremely useful, especially when we need to qualify how much risk is associated with changes.
Thanks!


More information about the svn-src-all mailing list