svn commit: r287578 - in head/usr.sbin/wpa: hostapd wpa_supplicant

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 09/08/2015 18:44, Adrian Chadd wrote:
> Wait a sec, did anyone review and test that this works out
> correctly?

I tested hostapd(8) with ath(4) myself and it is working flawlessly
for me.  I didn't get any review because I thought it wouldn't change
any default behavior.

> We already have working 802.11n; it's done inside net80211.

Yes, I know.  Basically, this commit let me set 802.11n via
hostapd.conf.  Previously, I had to manually set it via ifconfig(8).

> It also mostly adds 20/40 coexistence and channel width changing
> on the fly, which is absolutely going to break absolutely
> everything as we don't /have/ stable support for that in any
> driver.

Hmm...  I thought it has very low risk because user has to enable
802.11n for the driver (e.g., ATH_ENABLE_11N) and set it via
configuration (e.g., setting 'ieee80211n=1' in /etc/hostapd.conf).

> Not only that, but mwl firmware for freebsd doesn't even fully
> work with 802.11n out of the box anyway, it has bugs with dealing
> with aggregation. sigh.

Why don't we disable 802.11n support for mwl(4) by default and let the
user decide, just like we do for ath, then?

> So - please back this out and let's get this more thoroughly
> tested first. I don't want this update causing unpredictable
> behaviour.

Okay, I'll back it out.

Jung-uk Kim

> Thanks,
> 
> 
> 
> 
> -adrian
> 
> On 8 September 2015 at 14:04, Jung-uk Kim <jkim at freebsd.org>
> wrote:
>> Author: jkim Date: Tue Sep  8 21:04:33 2015 New Revision: 287578 
>> URL: https://svnweb.freebsd.org/changeset/base/287578
>> 
>> Log: Enable 802.11n support.
>> 
>> PR:           164102
>> 
>> Modified: head/usr.sbin/wpa/hostapd/Makefile 
>> head/usr.sbin/wpa/wpa_supplicant/Makefile
>> 
>> Modified: head/usr.sbin/wpa/hostapd/Makefile 
>> =====================================================================
=========
>>
>> 
- --- head/usr.sbin/wpa/hostapd/Makefile  Tue Sep  8 20:41:47 2015
(r287577)
>> +++ head/usr.sbin/wpa/hostapd/Makefile  Tue Sep  8 21:04:33 2015
>> (r287578) @@ -15,8 +15,8 @@ SRCS= accounting.c aes-omac1.c
>> ap_config eap_register.c eap_server.c eap_server_methods.c
>> eap_user_db.c \ eapol_auth_dump.c eapol_auth_sm.c eloop.c gas.c
>> gas_serv.c hostapd.c \ hs20.c http_client.c http_server.c
>> httpread.c \ -       hw_features_common.c ieee802_11_auth.c \ -
>> ieee802_11_common.c ieee802_11_shared.c ieee802_1x.c ip_addr.c \ 
>> +       hw_features_common.c ieee802_11_auth.c
>> ieee802_11_common.c \ +       ieee802_11_ht.c ieee802_11_shared.c
>> ieee802_1x.c ip_addr.c \ main.c ms_funcs.c os_unix.c
>> peerkey_auth.c pmksa_cache_auth.c \ preauth_auth.c radius.c
>> radius_client.c radius_das.c sta_info.c \ tkip_countermeasures.c
>> upnp_xml.c utils.c uuid.c vlan_init.c \ @@ -37,6 +37,7 @@ FILES=
>> hostapd.conf hostapd.eap_user hos CFLAGS+=-DCONFIG_DRIVER_BSD \ 
>> -DCONFIG_DRIVER_RADIUS_ACL \ -DCONFIG_HS20 \ +
>> -DCONFIG_IEEE80211N \ -DCONFIG_INTERWORKING \ -DCONFIG_PEERKEY \ 
>> -DCONFIG_RSN_PREAUTH \
>> 
>> Modified: head/usr.sbin/wpa/wpa_supplicant/Makefile 
>> =====================================================================
=========
>>
>> 
- --- head/usr.sbin/wpa/wpa_supplicant/Makefile   Tue Sep  8 20:41:47 2015
       (r287577)
>> +++ head/usr.sbin/wpa/wpa_supplicant/Makefile   Tue Sep  8
>> 21:04:33 2015        (r287578) @@ -40,6 +40,7 @@
>> CFLAGS+=-DCONFIG_BACKEND_FILE \ -DCONFIG_DRIVER_WIRED \ 
>> -DCONFIG_GAS \ -DCONFIG_HS20 \ +       -DCONFIG_IEEE80211N \ 
>> -DCONFIG_IEEE80211R \ -DCONFIG_INTERWORKING \ -DCONFIG_PEERKEY \
>> 
> .
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJV72uCAAoJEHyflib82/FGxgEH/jDCH6eSN5Go9tTEXgfofLxX
12DDoQjxMh2G5SPzkanYhjjljN2dYPt0+vaKUYELIdIcXblbcsXda81y2NjGX7lt
tu+L73cIfjmSvEo+vs/FJ9ERTk8DBTLSq2bU2I43gurhusqkAGnEeLGfrGchD7Dw
RDZnU99nLDYemr6NNzA8uIvLReIw8FTyg6Nsj6su9pvNvYh2x5YsNnXOBeGIi9Vj
2wDflU8tJ8WHYyjfHoSG790FiufEsW3A4O++YihzYHPODHsVN7qFCjgpQggti6Wy
fmYIOd9uEI/M0HT1CQ6sRgDxIqZr/ttG/1/iOQ8q8RhWrEBqhcBfQyYc1T+YLUc=
=UCLu
-----END PGP SIGNATURE-----