svn commit: r290135 - in head/sys: compat/linuxkpi/common/include/asm compat/linuxkpi/common/include/linux compat/linuxkpi/common/include/net compat/linuxkpi/common/src conf dev/usb modules/cxgb/iw...

[Jean-Sébastien Pédron]

On 29.10.2015 14:43, John Baldwin wrote:
> On Thursday, October 29, 2015 08:28:39 AM Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Thu Oct 29 08:28:39 2015
>> New Revision: 290135
>> URL: https://svnweb.freebsd.org/changeset/base/290135
>>
>> Log:
>>   Finish process of moving the LinuxKPI module into the default kernel build.
>>   
>>   - Move all files related to the LinuxKPI into sys/compat/linuxkpi and
>>     its subfolders.
>>   - Update sys/conf/files and some Makefiles to use new file locations.
>>   - Added description of COMPAT_LINUXKPI to sys/conf/NOTES which in turn
>>     adds the LinuxKPI to all LINT builds.
>>   - The LinuxKPI can be added to the kernel by setting the
>>     COMPAT_LINUXKPI option. The OFED kernel option no longer builds the
>>     LinuxKPI into the kernel. This was done to keep the build rules for
>>     the LinuxKPI in sys/conf/files simple.
>>   - Extend the LinuxKPI module to include support for USB by moving the
>>     Linux USB compat from usb.ko to linuxkpi.ko.
>>   - Bump the FreeBSD_version.
>>   - A universe kernel build has been done.
>>   
>>   Reviewed by:	np @ (cxgb and cxgbe related changes only)
>>   Sponsored by:	Mellanox Technologies
> 
> Humm.  Did you coordinate with dumbbell@ at all?  In his reviews on phabricator
> he had used subdirectories under linuxkpi for different versions Linux kernel
> versions.  At the very least it seems like he should have been on the review
> for this since he is working in the same area doing a very similar thing?

Hi!

Hans kept me in the loop. He did the work because Mellanox was
interested in this change and I have no time currently to work on this
topic.

My patch which allows to have multiple versions in parallel can be
recreated in the future. We decided to put everything in "common" for
now because we have no idea what version of Linux was used to create
this layer. And it probably does not track a specific version at all.

The layout is made so we can add version-specific implementations on top
of the common directory.

-- 
Jean-Sébastien Pédron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20151029/32b28718/attachment.bin>