svn commit: r289728 - head

[Warner Losh]

> On Oct 21, 2015, at 7:45 PM, Alexander Kabaev <kabaev at gmail.com> wrote:
> 
> On Thu, 22 Oct 2015 01:32:11 +0000 (UTC)
> Ed Maste <emaste at FreeBSD.org> wrote:
> 
>> Author: emaste
>> Date: Thu Oct 22 01:32:11 2015
>> New Revision: 289728
>> URL: https://svnweb.freebsd.org/changeset/base/289728
>> 
>> Log:
>>  Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>> 
>>  NO_CLEAN has been the correct spelling for over a decade.
>> 
>> Modified:
>>  head/Makefile.inc1
>> 
>> Modified: head/Makefile.inc1
>> ==============================================================================
>> --- head/Makefile.inc1	Thu Oct 22 01:04:31 2015
>> (r289727) +++ head/Makefile.inc1	Thu Oct 22 01:32:11
>> 2015	(r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
>> .endif	# !empty(SUBDIR_OVERRIDE)
>> 
>> .if defined(NOCLEAN)
>> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>> NO_CLEAN=	${NOCLEAN}
>> .endif
>> .if defined(NO_CLEANDIR)
> 
> 
> For some definition of 'correct'. It definitely is not for those who
> have -DNOCLEAN wired into their finger memory and above mentioned
> decade did not help with that any.
> 
> I think some of the common spellings were left as is in great NO_<foo>
> revolution for a reason and I see no reason why the sudden itch to
> change that.

There’s no sudden itch. We’ve been scratching at the NO_<foo> irritants
in the tree regularly for years, and more regularly in the past year. I
eliminated a boatload of them 9 months ago. More will go away.

Warner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20151021/01f0b9c6/attachment.bin>