svn commit: r289310 - vendor-sys/illumos/dist/common/zfs vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos...

[Andriy Gapon]

On 15/10/2015 17:41, Alexander Motin wrote:
> On 15.10.2015 18:26, Andriy Gapon wrote:
>> On 14/10/2015 13:12, Alexander Motin wrote:
>>> Author: mav
>>> Date: Wed Oct 14 11:12:47 2015
>>> New Revision: 289310
>>> URL: https://svnweb.freebsd.org/changeset/base/289310
>>>
>>> Log:
>>>   4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R
>>>   
>>>   Reviewed by: George Wilson <george.wilson at delphix.com>
>>>   Reviewed by: Prakash Surya <prakash.surya at delphix.com>
>>>   Reviewed by: Saso Kiselkov <saso.kiselkov at nexenta.com>
>>>   Reviewed by: Richard Lowe <richlowe at richlowe.net>
>>>   Approved by: Garrett D'Amore <garrett at damore.org>
>>>   Author: Matthew Ahrens <mahrens at delphix.com>
>>>   
>>>   illumos/illumos-gate at 45818ee124adeaaf947698996b4f4c722afc6d1f
>>>
>>> Added:
>>>   vendor/illumos/dist/common/crypto/
>>>   vendor/illumos/dist/common/crypto/edonr/
>>>   vendor/illumos/dist/common/crypto/edonr/edonr.c   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/edonr/edonr_byteorder.h   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/skein/
>>>   vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE.descrip   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/skein/skein.c   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/skein/skein_block.c   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/skein/skein_impl.h   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/skein/skein_iv.c   (contents, props changed)
>>>   vendor/illumos/dist/common/crypto/skein/skein_port.h   (contents, props changed)
>>
>> It seems that these are pieces of code that can be used by both the
>> userland and the kernel.  I think that previously we used to import such
>> code into illumos-sys and then integrate it into sys/cddl (e.g.
>> common/zfs/).  Perhaps it is worthwhile following that convention in
>> this case as well?
> 
> I haven't decided what to do with this specific case. As I understand,
> now we are using FreeBSD's native crypto code instead of illumos' one. I
> was thinking about importing this commit only in infrastructural parts,
> until respective algorithms are implemented in our native crypto. I
> think it should not be a problem for Skein, since according to comments
> it is in public domain. About Edon-R I am not sure, since it seems to be
> CDDL.
> 

This is confusing...  It seems that like you replied to my question in
another email, not the quoted one :-)

-- 
Andriy Gapon