svn commit: r288911 - head/share/mk

[Warner Losh]

On Wed, Oct 7, 2015 at 7:39 PM, Bryan Drewery <bdrewery at freebsd.org> wrote:

> On 10/6/2015 1:24 PM, Warner Losh wrote:
> >> With the META_MODE changes, sjg introduced this /etc/src-env.conf file
> >> that is included from sys.mk early, that can be used for overriding
> >> things like MAKEOBJDIRPREFIX, enabling META_MODE (it needs to be set
> >> extremely early for AUTO_OBJ support, among other things).
> >>
> >> As far as I can tell, the sys.mk change to include src.conf early was
> >> done out of convenience.  Meaning, we could remove that and just add
> >> back a .include <src.init.mk> or similar at the top of all src
> Makefiles.
> > All src makefiles? Yea, I’d rather hoped to avoid that, though it is
> easily
> > scripted. I’d thought of this solution at the time I did the MAKESYSPATH
> > hack, and rejected it as being too unwieldy. And having that at the top
> > of all the files would still require MAKESYSPATH need to be …/share/mk
> > to work out. I was rather hoping we could find some good way around
> > doing that.
>
> r289000 confuses me. Clearly src.opts.mk is still needed in Makefiles.
> So why are we including src.conf in sys.mk and not src.opts.mk?
>

We're including it there because Simon wanted it included there so
meta-mode settings were visible in sys.mk. I thought it lame at the
time, but had no better solution.

Warner