svn commit: r288911 - head/share/mk

[Simon J. Gerraty]

Bryan Drewery <bdrewery at FreeBSD.org> wrote:
> > Are you refering to a src/share/mk which is sibling to src/ports/* or
> > something else?
> > 
> > Because with  MAKESYSPATH=.../share/mk src/share/mk/sys.mk is what you
> > should find.
> 
> Right. That's what I'm referring to and what I prefer.

Ok good. 

> If we update our checked in share/mk/custom.sys.env.mk file, we want all
> builds to get it before having to install it to /usr/share/mk. We for a
> period were using a script to wrap make to setup the environment before
> we realized sys.mk was already capable of doing this. Being able to bind
> a build to a specific environment is important, vs using the environment
> installed from the last build or a foreign /usr/share/mk (FreeBSD's files).

Sure, we use a wrapper script as it keeps life simple.

> > But there's no reason you cannot make exceptions - by (as I think you
> > already mentioned) adding a check for $SRCTOP/ports in local*sys*mk
> > to suppress src.conf at least.
> > 
> 
> Yes that has been my local fix for now.

Ok - FWIW I don't see any particular problem with that.
 
> Perhaps my fix should get checked in so no one else is surprised by
> src.conf, and all of the tweaks its options set, coming in.

Not sure I'd go that far.
You could perhaps add a comment to src.conf for anyone who's frustrated?