svn commit: r288907 - head/bin/ls/tests

[John Baldwin]

On Tuesday, October 06, 2015 01:00:12 AM Garrett Cooper wrote:
> Author: ngie
> Date: Tue Oct  6 01:00:12 2015
> New Revision: 288907
> URL: https://svnweb.freebsd.org/changeset/base/288907
> 
> Log:
>   Call sync consistently using atf_check
>   
>   Remove superfluous sync's

You should not need to call sync() to see the results of earlier namespace
changes (file create, rename, delete, etc.), even for NFS when looking on the
same client that made the namespace change.

Are you doing this to force mtime updates?  You should not need sync() for
that on UFS (ufs_getattr() forces any pending lazy timestamp updates).  You
would for NFS (not sure about ZFS).

Whatever the reason for the syncs, I think it warrants a comment.

-- 
John Baldwin