svn commit: r290900 - head/sbin/restore
John-Mark Gurney
jmg at funkthat.com
Mon Nov 16 03:23:22 UTC 2015
Alexey Dokuchaev wrote this message on Mon, Nov 16, 2015 at 02:08 +0000:
> On Mon, Nov 16, 2015 at 01:29:59AM +0000, John-Mark Gurney wrote:
> > New Revision: 290900
> > URL: https://svnweb.freebsd.org/changeset/base/290900
> >
> > Log:
> > If you backup a large file that is mostly holes, previously we'd issue
> > a seek for every block... For large (Exabyte sized files) this would
> > issue lots of unneeded seeks, so combine them...
> >
> > [...]
> > @@ -938,14 +953,15 @@ getfile(void (*datafill)(char *, long),
> > {
> > int i;
> > off_t size;
> > + long seekpos;
>
> Briefly reading through tape.c, it looks like `long' is abused here (and in
> other places). IMHO we should try to fix these bugs, not add new misuses.
I agree... I'll ask if Jan is interested in fixing it, but it may need
to be added to the IdeasPage...
It'd also be good to have a test of regression tests for restore such
that changes can be verified not to break things..
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
More information about the svn-src-all
mailing list