svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys
Randall Stewart
rrs at netflix.com
Fri Nov 13 21:24:47 UTC 2015
Looking at the patch, we need a define of your
_callout_stop_safe
and we need to switch
callout_stop()’s define to use the new _callout_stop_safe()
R
On Nov 13, 2015, at 4:20 PM, Randall Stewart <rrs at netflix.com> wrote:
> No alexander’s panic’s are because the
> LLREF
> is done if (callout_stop())
>
> But now if it was not running -1 is returned..
>
> Try the patch I just sent..
>
> R
> On Nov 13, 2015, at 4:02 PM, Bryan Drewery <bdrewery at FreeBSD.org> wrote:
>
>> On 11/13/2015 1:00 PM, Randall Stewart wrote:
>>> Bryan:
>>>
>>> This looks like a decent thing to do..
>>>
>>> Still wondering why changing the callout.h header file would not have caused
>>> things to recompile to pick up the new argument..
>>>
>>> We can do it this way though it looks fine.
>>>
>>> You want to commit it or I?
>>
>> Well your change is totally safe for compiling. It's just not KBI
>> backwards compat for older modules. This is not typically a problem but
>> I think in this case it is worth doing to avoid random data coming into
>> the 'drain' argument if loading an older module.
>>
>> I'll do a test build and commit it. Perhaps this is what was leading to
>> Alexander's panics.
>>
>> I haven't analyzed the return value issue at all.
>>
>>
>> --
>> Regards,
>> Bryan Drewery
>>
>
> --------
> Randall Stewart
> rrs at netflix.com
> 803-317-4952
>
>
>
>
>
--------
Randall Stewart
rrs at netflix.com
803-317-4952
More information about the svn-src-all
mailing list