svn commit: r290505 - in head/sys: kern sys

NGie Cooper yaneurabeya at gmail.com
Sat Nov 7 20:13:35 UTC 2015


> On Nov 7, 2015, at 11:14, Bruce Evans <brde at optusnet.com.au> wrote:
> 
> On Sat, 7 Nov 2015, Conrad E. Meyer wrote:
> 
>> Log:
>> Flesh out sysctl types further (follow-up of r290475)
>> 
>> Use the right intmax_t type instead of intptr_t in a few remaining
>> places.
>> 
>> Add support for CTLFLAG_TUN for the new fixed with types.  Bruce will be
>> upset that the new handlers silently truncate tuned quad-sized inputs,
>> but so do all of the existing handlers.
> 
> I think I have complained about the getenv_*() integer functions before.
> All of them truncate or otherwise corrupt the value.  getenv_quad()
> does non-blind clamping using strtoq() followed by blind scaling in
> the suffix case.  All others use getenv_quad() with blind truncation,
> except on 64-bit arches long == quad so getenv_long() only has the same
> errors as getenv_quad().

Yes. I can’t find the exact thread (it was 3-5 years ago), but I was involved and I proposed a patch which didn’t make it into the tree.
Thanks,
-NGie


More information about the svn-src-all mailing list