svn commit: r283568 - head/sys/net80211

[Gleb Smirnoff]

On Tue, May 26, 2015 at 11:25:32AM -0700, Adrian Chadd wrote:
A> On 26 May 2015 at 08:44, Gleb Smirnoff <glebius at freebsd.org> wrote:
A> > On Tue, May 26, 2015 at 08:25:01AM -0700, Adrian Chadd wrote:
A> > A> Hi,
A> > A>
A> > A> We're going to have to move all of the counter API stuff into
A> > A> ieee80211_freebsd.[ch].
A> >
A> > Well, I put the function in the same file where if_get_counter pointer
A> > is set, so that it can be static. You need distinctive border between
A> > FreeBSD and non-FreeBSD stuff, which right now isn't yet clear.
A> >
A> > I don't mind moving, but looks like the ifnet attachment process, either
A> > the current one or the future one, also needs to be moved to FreeBSD
A> > part of the code.
A> 
A> Yeah, the lines got .. blurred. I don't want to go full portability
A> unless someone comes up with a very pressing need - eg, still assume
A> ifnet ,still assume ioctl ,transmit/start, receive, mbufs, etc. But
A> vnets and counter API should be easy to migrate out so
A> netbsd/dragonflybsd can port things.

Well, that's a good stuff to do goodness to others (Net/DragonFly), but in
these two particular cases (vnet/counter), they can deal with the problem
theirselves much easier:

typedef	counter_u64_t		u_int
#define	counter_u64_add(foo)	foo++
#define	CURVNET_SET(foo)	do {} while (0);
#define	CURVNET_RESTORE()	do {} while (0);

, than us modifing all the net80211 for the sake of hiding these APIs.

-- 
Totus tuus, Glebius.