svn commit: r283364 - head/sys/sys

John Baldwin jhb at freebsd.org
Mon May 25 11:45:14 UTC 2015


On Sunday, May 24, 2015 11:24:15 AM Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Sun May 24 11:24:14 2015
> New Revision: 283364
> URL: https://svnweb.freebsd.org/changeset/base/283364
> 
> Log:
>   Fix SIOCGI2C structure requirement.
>   
>   In reality, SIOCGI2C ioctl requires struct ifreq as many other
>   ioctls. Doing copyin() on (significantly) larger struct ifstat sometimes
>   triggered EFAULT.
>   
>   Reported by:	Olivier Cochard-Labbé <olivier at cochard.me>
>   MFC after:	1 week

Note that this breaks the ABI.  You may wish to add a SIOCGI2C_OLD that
still uses the larger struct so that old programs continue to work.  OTOH,
they were only working by accident before.  If we expect that no code
outside of ifconfig is using this yet, then it is probably ok to let this
slide.

-- 
John Baldwin


More information about the svn-src-all mailing list