svn commit: r282672 - head/etc/rc.d

[Eitan Adler]

On 10 May 2015 at 12:45, John Baldwin <jhb at freebsd.org> wrote:
>
>> On May 8, 2015, at 19:36, Xin LI <delphij at FreeBSD.org> wrote:
>>
>> Author: delphij
>> Date: Fri May  8 23:36:31 2015
>> New Revision: 282672
>> URL: https://svnweb.freebsd.org/changeset/base/282672
>>
>> Log:
>>  Always convert uuid to lower case.
>>
>>  MFC after:    2 weeks
>>
>> Modified:
>>  head/etc/rc.d/hostid
>>
>> Modified: head/etc/rc.d/hostid
>> ==============================================================================
>> --- head/etc/rc.d/hostid    Fri May  8 23:29:42 2015    (r282671)
>> +++ head/etc/rc.d/hostid    Fri May  8 23:36:31 2015    (r282672)
>> @@ -58,7 +58,7 @@ hostid_set()
>>
>> valid_hostid()
>> {
>> -    uuid=$1
>> +    uuid=$(echo $1 | tr '[:upper:]' '[:lower:]')
>
> tr is in /usr/bin so this breaks systems with a separate /usr.  Perhaps you could use dd with conv=lcase instead?

FWIW this broke hostid on my system, causing zfs to refuse to import
one of my pools.  In particular the lack of tr caused hostid to fail
entirely, causing the hostid to change each time.

Is there a reason that the uuid has to be lowercase in the first place?


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams