svn commit: r280430 - head/sys/dev/netmap

Bjoern A. Zeeb bz at FreeBSD.org
Tue Mar 24 09:46:48 UTC 2015


Author: bz
Date: Tue Mar 24 09:46:47 2015
New Revision: 280430
URL: https://svnweb.freebsd.org/changeset/base/280430

Log:
  Make ix_crcstrip a public symbol for the moment;  it probably is not
  the right solution but I will leave it to experts to untangle this
  problem to properly stop the build failures.
  
  At the moment only if_ix.c includes dev/netmap/ixgbe_netmap.h which is
  good as ixgbe_netmap.h defines a couple of (file) static variables--thus
  local to if_ix.c.
  static int ix_crcstrip however now also got checked from ix_txrx.c
  (as an extern) and should not be visible there.  In fact we do see
  powerpc and powerpc64 build failures because of this.  It is unclear
  to me why on other (clang built?) architectures this does not lead
  to a reference of an undefined symbol and similar build breakage.

Modified:
  head/sys/dev/netmap/ixgbe_netmap.h

Modified: head/sys/dev/netmap/ixgbe_netmap.h
==============================================================================
--- head/sys/dev/netmap/ixgbe_netmap.h	Tue Mar 24 09:21:53 2015	(r280429)
+++ head/sys/dev/netmap/ixgbe_netmap.h	Tue Mar 24 09:46:47 2015	(r280430)
@@ -61,7 +61,8 @@
  *	count packets that might be missed due to lost interrupts.
  */
 SYSCTL_DECL(_dev_netmap);
-static int ix_rx_miss, ix_rx_miss_bufs, ix_crcstrip;
+static int ix_rx_miss, ix_rx_miss_bufs;
+int ix_crcstrip;
 SYSCTL_INT(_dev_netmap, OID_AUTO, ix_crcstrip,
     CTLFLAG_RW, &ix_crcstrip, 0, "strip CRC on rx frames");
 SYSCTL_INT(_dev_netmap, OID_AUTO, ix_rx_miss,


More information about the svn-src-all mailing list