svn commit: r279828 - head/sys/dev/cadence
Scott Long
scott4long at yahoo.com
Tue Mar 10 19:39:51 UTC 2015
> On Mar 9, 2015, at 4:39 PM, Ian Lepore <ian at FreeBSD.org> wrote:
>
> Author: ian
> Date: Mon Mar 9 22:39:58 2015
> New Revision: 279828
> URL: https://svnweb.freebsd.org/changeset/base/279828
>
> Log:
> Use the new ifnet API. Also, allocate bus_dma_maps as needed instead of
> pre-allocating them all at start-up. Also fix a bug in cgem_stop(); before,
> it wasn't properly unloading dma maps due to a cut-and-paste error.
>
It’s generally a very bad idea to create and destroy maps for every transaction. If the map
results in being non-NULL, then you’re allocating and freeing memory on every transaction,
and possibly allocating and freeing large chunks of memory for bounce buffers. Is there
a reason why you’ve made this change?
Thanks,
Scott
More information about the svn-src-all
mailing list