svn commit: r284912 - head/usr.bin/units

Julio Merino jmmv at FreeBSD.org
Tue Jun 30 03:16:26 UTC 2015


> On Jun 28, 2015, at 15:05 , Garrett Cooper <yaneurabeya at gmail.com> wrote:
> 
> 
>> On Jun 28, 2015, at 09:43, Julio Merino <jmmv at FreeBSD.org> wrote:
>> 
>> Author: jmmv
>> Date: Sun Jun 28 16:43:07 2015
>> New Revision: 284912
>> URL: https://svnweb.freebsd.org/changeset/base/284912
>> 
>> Log:
>> Only initialize libedit when necessary
>> 
>> The code path to support units conversions from the command line
>> need not initialize neither libedit nor the history.  Therefore, only do
>> that when in interactive mode.
>> 
>> This hides the issue reported in PR bin/201167 whereby running commands
>> of the form 'echo "$(units ft in)"' would corrupt the terminal.  The real
>> issue causing the corruption most likely still remains somewhere.
>> 
>> PR:        bin/201167
>> Differential Revision:    D2935
>> Reviewed by:    eadler
> 
> Jenkins has been so messed up recently with timeouts and the like that it's hard to tell where things went south..
> 
> Can you please add your TERM and locale variables to the PR? I suspect that it might be a related issue..

Details added, but I don’t think they make a difference.  Could reproduce the above under multiple combinations.


More information about the svn-src-all mailing list