svn commit: r284644 - head/usr.sbin/fstyp

[Marcelo Araujo]

You should fix and upstream, I just did that last week.
On Jun 20, 2015 11:08 PM, "Allan Jude" <allanjude at freebsd.org> wrote:

> On 2015-06-20 11:05, Benjamin Kaduk wrote:
> > On Sat, Jun 20, 2015 at 11:03 AM, Allan Jude <allanjude at freebsd.org
> > <mailto:allanjude at freebsd.org>> wrote:
> >
> >     Author: allanjude (doc committer)
> >     Date: Sat Jun 20 15:03:02 2015
> >     New Revision: 284644
> >     URL: https://svnweb.freebsd.org/changeset/base/284644
> >
> >     Log:
> >       Fix the build for gcc by lowering the WARNS level
> >
> >
> > Are the warnings emitted by gcc posted somewhere so that I can convince
> > myself dropping WARNS is better than changing the code to work around
> them?
> >
> > -Ben
>
> The warnings come from the ZFS contrib code, so I was under the
> impression we didn't want to fix those and diverge form upstream.
>
> via kib on irc:
>
> ===> usr.sbin/fstyp (all)
> cc1: warnings being treated as errors
> In file included from
> /scratch/tmp/kib/src/usr.sbin/fstyp/../../sys/cddl/contrib
>                  from /scratch/tmp/kib/src/usr.sbin/fstyp/zfs.c:41:
> n/fs/zfs/sys/dmu.h:638: warning: function declaration isn't a prototype
> n/fs/zfs/sys/dmu.h:639: warning: function declaration isn't a prototype
>
> --
> Allan Jude
>
>