svn commit: r268137 - head/sys/sys

David Chisnall theraven at FreeBSD.org
Fri Jun 19 10:16:51 UTC 2015


I only just caught this (having seen the fallout from NetBSD doing the same thing in a shipping release and the pain that it’s caused):

__weak is a reserved keyword in Objective-C, please pick another name for this.  This in cdefs.h makes it impossible to include any FreeBSD standard headers in Objective-C programs (of which we have a couple of hundred in ports) if they use any of the modern Objective-C language modes.

David

> On 2 Jul 2014, at 09:45, Hans Petter Selasky <hselasky at FreeBSD.org> wrote:
> 
> Author: hselasky
> Date: Wed Jul  2 08:45:26 2014
> New Revision: 268137
> URL: http://svnweb.freebsd.org/changeset/base/268137
> 
> Log:
>  Define a "__weak" macro for declaring symbols "weak".
> 
> Modified:
>  head/sys/sys/cdefs.h
> 
> Modified: head/sys/sys/cdefs.h
> ==============================================================================
> --- head/sys/sys/cdefs.h	Wed Jul  2 05:45:40 2014	(r268136)
> +++ head/sys/sys/cdefs.h	Wed Jul  2 08:45:26 2014	(r268137)
> @@ -210,7 +210,9 @@
> #define	__packed
> #define	__aligned(x)
> #define	__section(x)
> +#define	__weak
> #else
> +#define	__weak		__attribute__((__weak__))
> #if !__GNUC_PREREQ__(2, 5) && !defined(__INTEL_COMPILER)
> #define	__dead2
> #define	__pure2
> 



More information about the svn-src-all mailing list