svn commit: r284336 - head/sys/dev/acpi_support

[Konstantin Belousov]

On Sat, Jun 13, 2015 at 03:31:16PM -0700, Garrett Cooper wrote:
> On Jun 13, 2015, at 4:30, Marcelo Araujo <araujobsdport at gmail.com> wrote:
> 
> > +1.
> 
> Fixed (r284357/r284358). Thanks!

I doubt that anything is fixed.

>From a little information I can gather from the r284336 commit message,
there was some NULL pointer dereference (may be not, FWIW). The r284336
papered over it, just ignoring the chunk of code when bith env variables
are _not_ NULL. Now, the condition is reversed, and since r284336
hide the bug, it is arguable that both env vars were not NULL on the
problematic machines.

The consequence is that the check is a nop now, since machines do have
valid SMBIOS info, and a bug, whatever it is, is not fixed, and probably
not even diagnosed.