svn commit: r284345 - in head: . bin/cat bin/chflags bin/chio bin/chmod bin/cp bin/csh bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/expr bin/freebsd-version bin/getfacl bin/hostname bi...

[Garrett Cooper]

On Jun 13, 2015, at 15:46, Garrett Cooper <yaneurabeya at gmail.com> wrote:

> On Jun 13, 2015, at 15:37, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> 
>> On Jun 13, 2015, at 15:34, Craig Rodrigues <rodrigc at FreeBSD.org> wrote:
>> 
>>> On Sat, Jun 13, 2015 at 12:20 PM, Simon J. Gerraty <sjg at freebsd.org> wrote:
>>> Author: sjg
>>> Date: Sat Jun 13 19:20:56 2015
>>> New Revision: 284345
>>> URL: https://svnweb.freebsd.org/changeset/base/284345
>>> 
>>> Log:
>>> Add META_MODE support.
>>> 
>>> Simon,
>>> 
>>> Can you take a look at this:
>>> https://jenkins.freebsd.org/job/FreeBSD_HEAD/2860/
>>> 
>>> 
>>> The console output is showing this:
>>> + make -j 4 buildworld __MAKE_CONF=/builds/FreeBSD_HEAD/make.conf
>>> make: "/builds/FreeBSD_HEAD/Makefile" line 102: Malformed conditional (${MK_META_MODE} == "yes")
>>> make: Fatal errors encountered -- cannot continue
>>> make: stopped in /builds/FreeBSD_HEAD
>>> Build step 'Execute shell' marked build as failure
>>> 
>>> This is using a FreeBSD 10.1 host to build HEAD.
>> 
>> The problem is that the bootstrapping capability has been broken with fmake. The quick fix would probably be to add MK_META_MODE?= yes to the Makefile.
>> 
>> We should probably keep the MK_ pollution in Makefile down to a minimum because of bootstrapping issues like this though.
> 
> Great. More breakage:
> 
> $ fmake buildworld
> 
> --------------------------------------------------------------
>>>> Building an up-to-date bmake(1)
> --------------------------------------------------------------
> "/usr/share/mk/bsd.links.mk", line 10: missing `in' in for
> t in ${LINKS}
> "/usr/share/mk/bsd.links.mk", line 13: for-less endfor
> "/usr/share/mk/bsd.links.mk", line 14: missing `in' in for
> t in ${SYMLINKS}
> "/usr/share/mk/bsd.links.mk", line 17: for-less endfor
> fmake: fatal errors encountered -- cannot continue
> *** [bmake] Error code 1
> 
> Stop in /usr/src.svn.
> *** [upgrade_checks] Error code 1
> 
> Stop in /usr/src.svn.

This has been broken for a while with fmake:

------------------------------------------------------------------------
r280122 | bapt | 2015-03-15 14:50:58 -0700 (Sun, 15 Mar 2015) | 8 lines

Symplify links installation by using multi variable for loop

Using multi variable for loop not only simplify the code, it also ensures that
the LINKS and SYMLINKS input have the right number of words

Differential Revision:  https://reviews.freebsd.org/D2069
Reviewed by:    imp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150613/1b4a49c9/attachment.sig>