svn commit: r283870 - head/sys/amd64/amd64

John Baldwin jhb at freebsd.org
Mon Jun 1 10:40:05 UTC 2015


On Monday, June 01, 2015 06:50:40 AM Dimitry Andric wrote:
> Author: dim
> Date: Mon Jun  1 06:50:39 2015
> New Revision: 283870
> URL: https://svnweb.freebsd.org/changeset/base/283870
> 
> Log:
>   Remove unneeded NULL checks in amd64's trap_fatal().
>   
>   Since td_name is an array member of struct thread, it can never be NULL,
>   so the check can be removed.  In addition, curproc can never be NULL,
>   so remove the if statement, and splice the two printfs() together.
>   
>   While here, remove the u_long cast, and use the correct printf format
>   specifier curproc->p_pid.
>   
>   Reviewed by:	kib
>   MFC after:	1 week
>   Differential Revision: https://reviews.freebsd.org/D2695

i386 has the curproc check and pid cast (it dates from < 5 when curproc was
NULL when a CPU was idle (we didn't have idle threads)).  Can you fix it as
well?

-- 
John Baldwin


More information about the svn-src-all mailing list