svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush usr.sbin/ypserv

[Marcelo Araujo]

Hello Ed,

Fixed, thank you very much.
https://svnweb.freebsd.org/base?view=revision&revision=285992

Best,

2015-07-28 15:05 GMT+08:00 Ed Schouten <ed at nuxi.nl>:

> Hi Marcelo,
>
> Thanks for working on this!
>
> 2015-07-28 4:32 GMT+02:00 Marcelo Araujo <araujo at freebsd.org>:
> > -struct ypalias {
> > +const struct ypalias {
> >         char *alias, *name;
> > -} ypaliases[] = {
> > +} static ypaliases[] = {
> >         { "passwd", "passwd.byname" },
> >         { "master.passwd", "master.passwd.byname" },
> >         { "shadow", "shadow.byname" },
>
> I seem to remember that certain compilers (Intel?) are pretty picky
> about the ordering of 'static' and 'const'.
>
> const static int i; // Compiler error.
>
> It's also inconsistent with the rest of our codebase, where we
> typically put 'static' in front of the type. Could you please change
> this to the following?
>
> static const struct ypalias {
>    ...
> } ypaliases[] = {
>    ...
> };
>
> Thanks!
>
> --
> Ed Schouten <ed at nuxi.nl>
> Nuxi, 's-Hertogenbosch, the Netherlands
> KvK/VAT number: 62051717
> _______________________________________________
> svn-src-head at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe at freebsd.org"
>



-- 

-- 
Marcelo Araujo            (__)araujo at FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>   \/  \ ^
Power To Server.         .\. /_)