svn commit: r277835 - in head: lib/libpmc sys/arm/arm sys/arm/include sys/arm/ti sys/conf sys/dev/hwpmc sys/sys

[Andrew Turner]

On Wed, 28 Jan 2015 18:39:13 +0000
Ruslan Bukin <br at FreeBSD.org> wrote:
> On Wed, Jan 28, 2015 at 09:35:03AM -0700, Ian Lepore wrote:
> > Just from a quick glance at the part that wasn't truncated, I
> > notice all the inline asm stuff is wrong -- it duplicates what's
> > already available in cpu-v6.h.
> > 
> 
> I had a conversation with Andrew this morning, he pointed me out
> those defines in cpu-v6.h, but we agreed those are optional stuff.
> I.e. duplicates != wrong. I'll fix that. Thanks

It would be useful to use them, but this will need Makefile changes as
some of these defines are only available when __ARM_ARCH > 6 which may
not be true in userland. If we do make these changes we then need to
make sure that none of the code on the file built as ARMv7 is run on an
ARMv6 as the compiler may choose to use invalid instructions on v6.

Andrew