svn commit: r277737 - in head: etc/pam.d tools/build/mk

[Dag-Erling Smørgrav]

Garrett Cooper <yaneurabeya at gmail.com> writes:
> I disagree for a few reasons:
> 1. style.Makefile(9) makes no mention of having to use an idiom over
> the other.

That is only one of many things it does not mention.  That doesn't mean
we don't have idioms and conventions outside what is described in that
document.

> 2. The likelihood of typos creeping into Makefiles is greater with the
> _foo= idiom.

I don't see how it makes a difference at all.

> 3. It creates unnecessary local variables — especially when appending
> is so easy to do.

Define unnecessary.  What is the marginal cost of a Makefile variable?

> 4. It’s more difficult when backporting changes to do it with the
> variable method — especially if context around the line modified has
> changed a great deal.

I don't see how it makes a difference.

DES
-- 
Dag-Erling Smørgrav - des at des.no