svn commit: r277511 - head/sys/dev/firewire
Ian Lepore
ian at freebsd.org
Thu Jan 22 16:49:18 UTC 2015
On Thu, 2015-01-22 at 16:26 +0000, Bjoern A. Zeeb wrote:
> > On 21 Jan 2015, at 20:08 , Will Andrews <will at FreeBSD.org> wrote:
> >
> > Author: will
> > Date: Wed Jan 21 20:08:24 2015
> > New Revision: 277511
> > URL: https://svnweb.freebsd.org/changeset/base/277511
> >
> > Log:
> > Fix remote DMA based firewire debugging when targeting
> > systems with more than 4GB of physical memory.
> >
> > To remotely debug the system 'stealthy' which has a kernel
> > with this change installed and firewire properly configured:
> >
> > % fwcontrol -m stealthy (or stealthy's firewire EUI64)
> > % kgdb kernel /dev/fwmem0.0
> >
> > sys/dev/firewire/fwohci.c:
> > Rather than hard code the upper limit for hw based
> > automatic responses to remote DMA requests at 4GB,
> > program the hardware using Maxmem, the page number
> > one higher than the highest physical page detected
> > in the system.
> >
> > While here, garbage collect more useless splfw()
> > calls.
> >
> > Submitted by: gibbs
> > MFC after: 1 week
> > Sponsored by: Spectra Logic
> > MFSpectraBSD: 1110994 on 2015/01/06
>
> arm doesn’t define a Maxmem; the kernel builds are thus currently broken.
>
> converting beaglebone.dts -> /storage/head/obj/arm.armv6/scratch/tmp/bz/head.svn/sys/BEAGLEBONE/beaglebone.dtb
> /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewire/fwohci.c:1856:28: error: use of undeclared identifier 'Maxmem'
> prequpper = ((uintmax_t)Maxmem << PAGE_SHIFT) >> 16;
> ^
> /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewire/fwohci.c:1862:20: error: use of undeclared identifier 'Maxmem'
> (uintmax_t)Maxmem << PAGE_SHIFT,
> ^
> 2 errors generated.
This is the first I've heard of Maxmem. I think I can get it added to
arm pretty quickly.
-- Ian
More information about the svn-src-all
mailing list