svn commit: r277072 - head/sys/netinet6

Gleb Smirnoff glebius at FreeBSD.org
Mon Jan 12 16:16:51 UTC 2015


On Mon, Jan 12, 2015 at 08:09:18AM -0800, Adrian Chadd wrote:
A> On 12 January 2015 at 07:09, Alexander V. Chernikov
A> <melifaro at freebsd.org> wrote:
A> > On 12.01.2015 17:52, Gleb Smirnoff wrote:
A> >> Author: glebius
A> >> Date: Mon Jan 12 14:52:43 2015
A> >> New Revision: 277072
A> >> URL: https://svnweb.freebsd.org/changeset/base/277072
A> >>
A> >> Log:
A> >>   Do not go one layer down to check ifqueue length. First, not all drivers
A> >>   use ifqueue at all. Second, there is no point in this lockless check.
A> >>   Either positive or negative result of the check could be incorrect after
A> >>   a tick.
A> > Finally, no useless ifq_maxlen check!
A> 
A> Yeah, I killed it in the ipv4 world. Well, commented it out. It's been
A> bogus ever since kernels became re-entrant and SMP. :(

Another one (even with extra mistake) left in ip_fastfwd.c until today.

One still left in SCTP output code, waiting for maintainers to review it.

-- 
Totus tuus, Glebius.


More information about the svn-src-all mailing list